Skip to content

Fix #7537 "cannot be represented as URI" in JDK 13 #7538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix #7537 "cannot be represented as URI" in JDK 13 #7538

merged 1 commit into from
Nov 12, 2019

Conversation

izhangzhihao
Copy link
Contributor

@izhangzhihao izhangzhihao commented Nov 12, 2019 •
edited
Loading

Fix #7537
Taken from scala/scala#8210.

dottybot
dottybot reviewed Nov 12, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

smarter
smarter approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smarter
Copy link
Member

smarter commented Nov 12, 2019

Do you mind signing the Scala CLA at https://www.lightbend.com/contribute/cla/scala ? It's not technically required here since this is just porting existing ocde but it's easier for us if everyone signs it.

@izhangzhihao
Copy link
Contributor Author

CLA signed!

@nicolasstucki
Copy link
Contributor

It still says it is not signed https://www.lightbend.com/contribute/cla/scala/check/izhangzhihao

@izhangzhihao could you sign it again to make sure?

@izhangzhihao
Copy link
Contributor Author

The site says "Thank you! Your submission was processed.", but still got a false sign.

@izhangzhihao
Copy link
Contributor Author

It's done now.

@nicolasstucki
Copy link
Contributor

Yes, now I saw it

@nicolasstucki nicolasstucki merged commit 7d50bdb into scala:master Nov 12, 2019
@sighoya
Copy link

sighoya commented Dec 17, 2019

Which stable dotty/scala version will provide this fix, I'm waiting on Arch Linux to get support for JDK 13, my current versions are:
0.12.0 for dotty
2.13.0-20190613-143643-unknown for scala

@nicolasstucki
Copy link
Contributor

Not sure if it made it into 0.20. We are going to release 0.21 soon which will contain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@dottybot dottybot Awaiting requested review from dottybot

Assignees

@izhangzhihao izhangzhihao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packages cannot be represented as URI
5 participants
@izhangzhihao @smarter @nicolasstucki @sighoya @dottybot