Skip to content

Fix #7525: Allow static methods having body in JavaParser #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2019
Merged

Fix #7525: Allow static methods having body in JavaParser #7534

merged 2 commits into from
Nov 12, 2019

Conversation

noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Nov 11, 2019 •
edited
Loading

Related issue: #7525

@noti0na1 noti0na1 requested a review from bishabosha November 11, 2019 21:02
dottybot
dottybot reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

bishabosha
bishabosha reviewed Nov 11, 2019
View reviewed changes
@bishabosha
Copy link
Member

Otherwise looks good to me :)

@nicolasstucki nicolasstucki merged commit bb96612 into scala:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noti0na1 @bishabosha @dottybot @nicolasstucki