Fix #7519: Check PCP of constructor calls on the type #7531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect when a a reference to a constructor is a static path. Also fix `isTerm` and `isType` on `Hole`. We do not pickle this extra info as when we unpickle it we already know if it will be a type or a term.
This comment has been minimized.
This comment has been minimized.
liufengyun
reviewed
Nov 11, 2019
| @@ -157,6 +157,8 @@ class ReifyQuotes extends MacroTransform { | |||
| val tagDef = tagDefCache.getOrElseUpdate(prefix.symbol, mkTagSymbolAndAssignType(prefix)) | |||
| tagDef.symbol.typeRef | |||
| } | |||
| case AnnotatedType(parent, _) => | |||
| apply(parent) // Only keep the Annotated tree | |||
There was a problem hiding this comment.
Does it mean it throws the annotation away? That will make it impossible to keep some annotations in types.
There was a problem hiding this comment.
We throw away the annotation on the type but then recover it from the Annotated type tree while unpickling.
Maybe I should only do it if it contains a splice. In that case we would always have the tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when a a reference to a constructor is a static path.
Also fix
isTermandisTypeonHole. We do not pickle this extrainfo as when we unpickle it we already know if it will be a type or a term.