Change Tasty parameter encoding #7504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New way is to have PARAM, TYPEPAAM, and PARAMEND tags. A PARAMEND is needed to mark a preceding empty parameter section, or a following parameter section. Bumps Tasty version.
bishabosha
reviewed
Nov 6, 2019
| Param = PARAM Length NameRef type_Term rhs_Term? Modifier* -- modifiers name : type (= rhs_Term)?. `rhsTerm` is present in the case of an aliased class parameter | ||
| Template = TEMPLATE Length TypeParam* Params* parent_Term* Self? Stat* -- [typeparams] paramss extends parents { self => stats }, where Stat* always starts with the primary constructor. | ||
| PARAMEND -- ends a parameter clause | ||
| -- needed if previous parameter clause is empty or another parameter clause follows |
There was a problem hiding this comment.
The indentation doesn't line up here
bishabosha
reviewed
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new scheme is to drop PARAMS and to have PARAM, TYPEPARAM, and PARAMEND tags instead.
A PARAMEND is needed to mark a preceding empty parameter section,
or a following parameter section.
The advantage of the new scheme is that it also accommodates a possible generalisation of the language that allows interspersed type params and normal params as well as curried type params.
If we ever want to allow this, we can simply relax the posisble order of these sections; no new tags would be needed.
Bumps Tasty version.