Fix #7434: Tighten a condition in LazyVals #7435
Conversation
| // For non-private trait members we can check whether there is an overridden symbol. | ||
| // For private trait members this does not work, since `ensureNotPrivate` in phase Mixins | ||
| // does change the name but does not update the owner's scope, so `allOverriddenSymbols` does | ||
| // not work in that case. However, we can check whether the name is an ExpandedName instead. |
There was a problem hiding this comment.
I think the code is a little brittle.
The optimization was introduced in 8f47f16 to fix #676 . Since #4090, we no longer generate companion objects in FirstTransform anymore, it seems we can just disable the optimization.
If the optimization is needed, what about using a compiler flag to flag an object as eager, and we only check flags here? That flag could also be reused to enable more optimization opportunities without worrying about semantic problems.
There was a problem hiding this comment.
Even with automatic generation of companion objects disabled, I believe there are still a lot of them, so it's worthwhile to optimize. But the criterion as it stands is somewhat arbitrary and could be improved. E.g. we could also strictify companion objects that are pure.
No description provided.