Disambiguate quoted and tasty Type #7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
disambiguate-quoted-type-and-reflection-type
branch
2 times, most recently
from
2cff8d7 to
17d3c43
Compare
To avoid losing history
nicolasstucki
force-pushed
the
disambiguate-quoted-type-and-reflection-type
branch
3 times, most recently
from
dba4b35 to
ad9c308
Compare
This ambiguity can be seen in the following
```scala
import scala.quoted._
def f[T: Type](given qctx: QuoteContext) = {
import qctx.tasty._
...
summon[Type[T]] // qctx.tasty.Type instead of scala.quoted.Type
...
}
```
To avoid the ambiguity we simply rename `scala.quoted.Type` to `TypeTag`.
From the 2 this is the one that conforms the least to the common expectation of
what is a `Type`. We chose `TypeTag` because it encapsulates the same kind
of information that `scala.reflect.TypeTag` did.
nicolasstucki
force-pushed
the
disambiguate-quoted-type-and-reflection-type
branch
from
ad9c308 to
4ce1f56
Compare
|
This is a drastic but necessary change. The sooner we make the change, the simpler it will be for users. |
|
@milessabin this also added a minor change to shapeless |
|
@nicolasstucki thanks for the heads up! |
|
@milessabin we actually reverted this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ambiguity can be seen in the following
To avoid the ambiguity we simply rename
scala.quoted.TypetoTypeTag.From the 2 this is the one that conforms the least to the common expectation of
what is a
Type. We choseTypeTagbecause it encapsulates the same kindof information that
scala.reflect.TypeTagdid.