Skip to content

Fix #7323: Fix missing PCP check for path dependent type #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fix #7323: Fix missing PCP check for path dependent type #7366

merged 1 commit into from
Oct 4, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 3, 2019 •
edited
Loading

No description provided.

@nicolasstucki nicolasstucki self-assigned this Oct 3, 2019
@nicolasstucki
Copy link
Contributor Author

Note that the pseudo fix for #7048 causes more alarming bugs.

@nicolasstucki nicolasstucki marked this pull request as ready for review October 4, 2019 11:21
@nicolasstucki
Copy link
Contributor Author

It is better to reopen the feature request in #7048 than have a bug that crashes the compiler.

liufengyun
liufengyun approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 736af36 into scala:master Oct 4, 2019
@nicolasstucki nicolasstucki deleted the fix-#7323 branch October 4, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun