Fixes #7359 - Fix SAM processing #7360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Oct 3, 2019
compiler/src/dotty/tools/backend/jvm/DottyBackendInterface.scala
Outdated
Show resolved
Hide resolved
neshkeev
commented
Oct 10, 2019
neshkeev
changed the title
Dotty used to call the Types.abstractTermMembers method to find all the methods that might be used as candidates for SAM. But the method ignores the methods of java.lang.Object's when processing a list of a term's members and returns all the members that have no implementation. This used to cause the problem when there are overridden java.lang.Object methods in a trait. Such methods receive implementation by default so they cannot be considered as candidates for SAM methods. This problem prevents Dotty from recognising some traits as SAM. Now the Types.possibleSamMethods method is used in order to filter out all the overridden java.lang.Object methods that does not have an implementation yet. This patch applies additional predicate to Types.abstractTermMembers to filter out all the overridden java.lang.Object methods. Signed-off-by: Nikita Eshkeev <[email protected]>
smarter
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to start sharing my progress on the #7359 issue in this pull-request.
So far I have came across the problem with
java.util.Comparator, which happens to contains overriddenequalsmethod. Javadoc states that overridden methods ofjava.lang.Objecthave to be ignored:Dotty finds two abstract methods (
equalsandcompare) in this@FunctionalInterfaceobject and fails to recognize it asSAMand hence fails to assign a proper type to it.