Skip to content

Tasty reflect symbol refactorings #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 25, 2019

  • Remove subtypes of Symbol
  • Remove logic duplication
  • Remove unnecessary Options from API

@nicolasstucki nicolasstucki self-assigned this Sep 25, 2019
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-symbol-refactorings branch from 3e374d9 to 5952072 Compare September 25, 2019 08:09
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-symbol-refactorings branch from 5952072 to 1070c7d Compare September 25, 2019 09:05
@nicolasstucki
Copy link
Contributor Author

@milessabin this PR will update a file in shapeless

@nicolasstucki nicolasstucki marked this pull request as ready for review September 25, 2019 09:07
@milessabin
Copy link
Contributor

@nicolasstucki thanks for the heads up!

@smarter

This comment has been minimized.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki

This comment has been minimized.

@smarter

This comment has been minimized.

@nicolasstucki nicolasstucki force-pushed the tasty-reflect-symbol-refactorings branch from b44b926 to 0967883 Compare September 26, 2019 11:04
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-symbol-refactorings branch from 0967883 to d8d28bd Compare September 26, 2019 11:18
@nicolasstucki nicolasstucki merged commit 869bca6 into scala:master Sep 26, 2019
@nicolasstucki nicolasstucki deleted the tasty-reflect-symbol-refactorings branch September 26, 2019 14:23
@milessabin milessabin mentioned this pull request Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants