Skip to content

Enable javalib math sjs tests #7272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Enable javalib math sjs tests #7272

merged 1 commit into from
Sep 20, 2019

Conversation

neshkeev
Copy link
Contributor

@neshkeev neshkeev commented Sep 19, 2019

All tests from the javalib/math group has been enabled, no failing tests of the group were discovered

@neshkeev
Copy link
Contributor Author

The pull-request has been simplified:

  1. there is only one commit
  2. single *.scala is used instead of the whole list of all the tests from the directory.

@sjrd
Copy link
Member

sjrd commented Sep 20, 2019

Cool thanks! You might want to adapt the commit message to say that it adds all math.* tests instead of just BigDecimalTest ;)

@neshkeev
Copy link
Contributor Author

Right, totally missed that, I will fix it soon

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@sjrd sjrd merged commit 8258caf into scala:master Sep 20, 2019
@neshkeev neshkeev deleted the enable-javalib-math-sjs-tests branch September 20, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants