Skip to content

Drop old syntax styles for givens #7245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 18, 2019
Merged

Drop old syntax styles for givens #7245

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
57d5b21
Drop `delegate`
odersky Sep 17, 2019
898e45f
Change name generation scheme for anonymous givens.
odersky Sep 17, 2019
6b73bbd
Drop `given as` syntax
odersky Sep 17, 2019
44f7575
Drop `given as` in tests
odersky Sep 17, 2019
0b27321
Fixes to erased and others
odersky Sep 17, 2019
24dc2de
Adapt xml interpolator to new given syntax
odersky Sep 17, 2019
4f437ae
More fixes in code and tests
odersky Sep 17, 2019
fc8e1cd
Fix regex replace breakage
odersky Sep 18, 2019
45cba37
Adapt CB projects to new given syntax
odersky Sep 18, 2019
f224aad
More fixes
odersky Sep 18, 2019
40c9bc8
Adapt CB projects to new given syntax
odersky Sep 18, 2019
25af1de
Switch to new syntax for printing method types
odersky Sep 18, 2019
ff43466
Update docs/docs/reference/metaprogramming/macros-spec.md
nicolasstucki Sep 18, 2019
14c4366
Add missing Str
nicolasstucki Sep 18, 2019
30ccaf6
Fix tests
nicolasstucki Sep 18, 2019
7bc9741
Update repl test output
nicolasstucki Sep 18, 2019
df6db9a
Update test
nicolasstucki Sep 18, 2019
1f08e5b
Update `the` to `summon`
nicolasstucki Sep 18, 2019
c5ca1f8
Use keywordText for argument modifiers
nicolasstucki Sep 18, 2019
4d79c90
Fix repl-staging test
nicolasstucki Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/docs/reference/metaprogramming/macros-spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ extends simply-typed lambda calculus with quotes and splices.

### Syntax

The syntax of terms, values, and types is given follows:
The syntax of terms, values, and types is given as follows:

Terms t ::= x variable
(x: T) => t lambda
Expand Down Expand Up @@ -239,4 +239,4 @@ downright pleasant. A simple strategy first defines the underlying quoted or unq
values using `Expr` and `Type` and then inserts quotes and splices to make the types
line up. Phase consistency is at the same time a great guideline
where to insert a splice or a quote and a vital sanity check that
the result makes sense.
the result makes sense.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the added and removed lines look indentical?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an extra space at the end of the line. If you select it you can see it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I can't see it when selecting the line. Also, Github highlights changes in spaces by default.