Skip to content

Update and reenable shapeless in community build #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

milessabin
Copy link
Contributor

Fix breakage following #7210.

@milessabin
Copy link
Contributor Author

@nicolasstucki this adapts shapeless to #7210, but I'm not clear if a fix for #7238 will break things.

Feel free to merge this now, or hold off until later.

@nicolasstucki
Copy link
Contributor

I would suggest merging it. We can fix it while fixing #7238 or disable it temporarily again if it is a blocker.

@odersky WDYT?

@odersky
Copy link
Contributor

odersky commented Sep 18, 2019

@milessabin It would be best to wait until #7245 is in. Otherwise we have to disable it again for that one, or fix it on the fly. But I prefer it if you could do the fixes to adapt to the new style since it would be good to get feedback how the new style works in your case.

@milessabin
Copy link
Contributor Author

@odersky that's fine. Ping me when #7245 is in its final form.

@milessabin
Copy link
Contributor Author

Updated post #7245.

I'll merge when it goes green.

@milessabin
Copy link
Contributor Author

@odersky I hugely prefer the realignment with method syntax for givens 👍

@milessabin
Copy link
Contributor Author

Green now.

@milessabin milessabin merged commit dd68eb8 into scala:master Sep 18, 2019
@milessabin milessabin deleted the topic/update-shapeless branch September 18, 2019 13:33
@odersky
Copy link
Contributor

odersky commented Sep 18, 2019

@odersky I hugely prefer the realignment with method syntax for givens 👍

Yes, it does come out much nicer that way! Kudos to @smarter for quietly insisting on the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants