Skip to content

Enable more sjs tests #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Enable more sjs tests #7236

merged 5 commits into from
Sep 17, 2019

Conversation

neshkeev
Copy link
Contributor

Enable the following tests for Scala.JS

  1. javalib/lang/DoubleTest
  2. javalib/lang/CharacterTest
  3. javalib/lang/ByteTest
  4. javalib/lang/BooleanTest
  5. javalib/lang/FloatTest

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki nicolasstucki merged commit a59c067 into scala:master Sep 17, 2019
@nicolasstucki
Copy link
Contributor

Thanks @neshkeev

@neshkeev neshkeev deleted the enable-more-sjs-tests branch September 19, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants