Fix #3559: fix scope for typing this(...) in 2nd constructor #7200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scope for typing `this(...)` should include both constructor params and local defs. The latter are included to provide more friendly error messages for references to local definitions.
odersky
requested changes
Sep 12, 2019
There was a problem hiding this comment.
What's important is that a supercall cannot see any members of the enclosing class (defined or inherited). If it could access such members we would get a verify error on the bytecode.
I am not certain whether the change in this PR maintains this restriction. Can we add a neg test that demonstrates that neither defined nor inherited members can be accessed?
odersky
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3559: fix scope for typing this(...) in 2nd constructor
The scope for typing
this(...)should include bothconstructor params and local defs. The latter are
included to provide more friendly error messages
for references to local definitions.