Fix #6989: Make sure scalacLinkedClass finds companion when unpickling #7101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckling scalacLinkedClass uses unforcedDecls which might miss a companion object when unpickling. I tried to make scalacLinekdClass stricter, but ran into problems. It turns out that it is finely balanced as it is. The fix is to make sure the owner is completed before calling scalacLinkedClass from an unpickler. I trued to do the same for the Scala2Unpickler but that ran again into problems. So this is quite the mine-field...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalacLinkedClass uses unforcedDecls which might miss a companion object when
unpickling. I tried to make scalacLinekdClass stricter, but ran into
problems. It turns out that it is finely balanced as it is.
The fix is to make sure the owner is completed before calling scalacLinkedClass
from an unpickler.