Fix #7084: Drop revealProtoOfExtMethod #7093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call `revealProtoOfExtMethod` wehn constraining results in adaptation. Revealing the proottype too early disables further implicit searches, as is demonstrated by i7084.scala. The original reason to have `revealProtoOfExtMethod` was to typecheck i5773a. But it looks like this is no longer valid. i5773a now compiles regardless.
We get in both cases a type difference where one side is an unreduced match type and the other side is its redux.
anatoliykmetyuk
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call
revealProtoOfExtMethodwhen constraining results in adaptation.Revealing the prototype too early disables further implicit searches, as is
demonstrated by i7084.scala. The original reason to have
revealProtoOfExtMethodwas to typecheck i5773a. But it looks like this is no longer valid. i5773a
now compiles regardless.