Add a Var abstraction in QuoteUtils #7035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biboudis
force-pushed
the
add-quote-utils
branch
from
b37e461 to
a4c771c
Compare
nicolasstucki
previously requested changes
Aug 13, 2019
biboudis
force-pushed
the
add-quote-utils
branch
from
a4c771c to
89b42cf
Compare
| /** Create a variable initialized with `init` and used in `body`. | ||
| * `body` recieves a `Var[T]` argument which exposes `get` and `update`. | ||
| * | ||
| * `var`('(7)) { |
There was a problem hiding this comment.
@biboudis, you forgot to adapt the comment. It should be Var(.... Also need to update the quote and splice syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted a small abstraction for vars with
update/getin a standalone packagescala.quoted.util.The motivation behind this is that sometimes we need to pass around variable references in a quoted program and maintain variable binding (demonstrated in the
staged-streamstest).