Revert Definitions Changes #6962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(reverted from commit 1abbf4e)
|
test performance please |
Use an IFT instead of duplicating Type and Symbol definitions everywhere. (reverted from commit 45917fc)
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6962/ to see the changes. Benchmarks is based on merging with master (0b52037) |
|
We have to decide between this PR and #6965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplifications in Definitions caused a big drop in performance. Reverting bit by bit to see what caused it.