Fix #6142: remove unreasonable type change for _ #6897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic was introduced in f618e47, which is hard to justify. The problem is exhibited in tests/pos/i6142.scala, where we have code lik the following: implicit val _: scala.quoted.Type = ... { def $anon$ = _ closure($anon$) } Changing the type of `_` will break LambdLift (`_` is not free anymore), and the compiler crashes at backend when generating code for the unfound local variable `_`, whose symbol is `scala.quoted.Type`.
nicolasstucki
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was introduced in f618e47, which is hard to justify.
The problem is exhibited in tests/pos/i6142.scala, where
we have code lik the following:
Changing the type of
_will break LambdLift (_is not free anymore),and the compiler crashes at backend when generating code for the unfound local variable
_,whose symbol is
scala.quoted.Type.