Skip to content

Cleanup quoted.{Expr|Type} APIs #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2019
Merged

Cleanup quoted.{Expr|Type} APIs #6867

merged 4 commits into from
Jul 17, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Make show a proper method of Expr and type
8b83989 
Now that there is a single show implementation we do not need to have it as an extension method
@nicolasstucki nicolasstucki requested a review from liufengyun July 17, 2019 09:04
@nicolasstucki nicolasstucki self-assigned this Jul 17, 2019
@liufengyun liufengyun marked this pull request as ready for review July 17, 2019 09:35
liufengyun
liufengyun approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 1beb55f into scala:master Jul 17, 2019
@liufengyun liufengyun deleted the cleanup-quoted-expr-and-type-api branch July 17, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun