Handle $asInstanceOf$ in Splicer #6844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Jul 15, 2019
|
This PR needs a rebased on master |
Before that commit macro expansion would fail with: "Could not find method Box$.$asInstanceOf$ with parameters (). The most common reason for that is that you apply macros in the compilation run that defines them"
OlivierBlanvillain
force-pushed
the
handle-$asInstanceOf$
branch
from
3070bb3 to
f8a5424
Compare
nicolasstucki
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that commit macro expansion would fail with:
"Could not find method Box$.$asInstanceOf$ with parameters (). The most common reason for that is that you apply macros in the compilation run that defines them"
The code in question comes from the way we handle
Mirrors; when implicitly summoned they get a more precise type via a cast.Doing this by name feels hacky but I'm still opening the PR for discussion.