Skip to content

Fix #6834: Make module constructors private #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2019
Merged

Fix #6834: Make module constructors private #6836

merged 2 commits into from
Jul 11, 2019

Conversation

anatoliykmetyuk
Copy link
Contributor

Now let us see exactly at which place it breaks and why that was commented out in first place...

@anatoliykmetyuk anatoliykmetyuk marked this pull request as ready for review July 11, 2019 08:00
@allanrenucci
Copy link
Contributor

We could add a bytecode test

@anatoliykmetyuk anatoliykmetyuk merged commit 11dd2bb into scala:master Jul 11, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the private-module-constructors branch July 11, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatoliykmetyuk @allanrenucci @nicolasstucki