Split macro body check from interpreter #6831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
split-macro-body-check-from-interpreter
branch
2 times, most recently
from
6d9f314 to
489a396
Compare
nicolasstucki
force-pushed
the
split-macro-body-check-from-interpreter
branch
2 times, most recently
from
1764e28 to
73bf699
Compare
nicolasstucki
force-pushed
the
split-macro-body-check-from-interpreter
branch
from
b838d71 to
00c7125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the same code is used to check that the macro bodies are valid and to interpret the tree.
Adding more functionality to the interpreters usually ends up affecting the validity check. This has proven to allow unexpected arguments to be accepted in the macro body.
The solution is to split the two implementations. The validity check will accept a subset of the trees that the interpreter can handle.