Skip to content

Always require QuoteContext #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jul 8, 2019
@nicolasstucki nicolasstucki force-pushed the use-QuoteContext-for-unpickling branch 2 times, most recently from c1eec3f to 18a9a3a Compare July 8, 2019 06:27
@nicolasstucki nicolasstucki force-pushed the use-QuoteContext-for-unpickling branch from 18a9a3a to 03ef96f Compare July 8, 2019 13:41
@nicolasstucki nicolasstucki changed the title Use QuoteContext for unpickling Always require QuoteContext Jul 9, 2019
@nicolasstucki nicolasstucki requested a review from liufengyun July 9, 2019 11:29
def fn(e : Expr[T]) given QuoteContext: Expr[T] = '{ println(); $e }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quote accidentally got optimized away, hence not testing for #6008

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun marked this pull request as ready for review July 9, 2019 11:38
@nicolasstucki nicolasstucki marked this pull request as ready for review July 9, 2019 11:40
@nicolasstucki nicolasstucki merged commit cba756d into scala:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants