Skip to content

Make links relative and to .md (instead of .html) #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

sideeffffect
Copy link
Contributor

this PR also contains some fixed broken links

change from .html to .md

  • makes the pages browseable even from GtiHub
  • IntelliJ or other tools mark broken links (with .html every link is marked as broken), preventing them from ever getting to master
  • should translate to .html without any problem; in the past, for example

the source given instances links to ./delegates.md
and
the rendered given instances links to https://dotty.epfl.ch/docs/reference/contextual/delegates.html

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@sideeffffect
Copy link
Contributor Author

I've signed the CLA. What am I doing wrong? :(

@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Jul 5, 2019

The CLA is signed, the bot sometimes gets confused about it. Thanks for the contribution!

@anatoliykmetyuk anatoliykmetyuk merged commit 32012f7 into scala:master Jul 5, 2019
@sideeffffect sideeffffect deleted the doc-typo-fix branch July 5, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants