Skip to content

Fix inner object macro implementations #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

The interpreter did not load inner objects with the correct class name.

@nicolasstucki nicolasstucki force-pushed the fix-inner-object-macro-implimentation branch from e11964e to 379765e Compare July 4, 2019 16:21
@nicolasstucki nicolasstucki requested a review from liufengyun July 4, 2019 16:29
The interpreter did not load inner objects with the correct class name.
@nicolasstucki nicolasstucki force-pushed the fix-inner-object-macro-implimentation branch from 379765e to 385f347 Compare July 4, 2019 17:51
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@odersky
Copy link
Contributor

odersky commented Jul 4, 2019

I recommend naming the PR Fix #6803: ..., then the issue is closed automatically on merge.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jul 5, 2019

This does not fully fix the issue #6803. It is not even fixing the main bug discussed in that issue.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 560b220 into scala:master Jul 5, 2019
@nicolasstucki nicolasstucki deleted the fix-inner-object-macro-implimentation branch July 5, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants