Skip to content

Remove useless constant extractors #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 3, 2019

Now that we have an extractor/constructor using union types we do not need all the variants with more precise types.

@nicolasstucki nicolasstucki force-pushed the remove-useless-constant-extractors branch 4 times, most recently from 512247d to 125b0e1 Compare July 3, 2019 17:22
@nicolasstucki nicolasstucki force-pushed the remove-useless-constant-extractors branch from 125b0e1 to 8174075 Compare July 4, 2019 11:46
@nicolasstucki nicolasstucki marked this pull request as ready for review July 4, 2019 12:41
@nicolasstucki nicolasstucki requested a review from liufengyun July 4, 2019 12:41
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 06204ea into scala:master Jul 4, 2019
@nicolasstucki nicolasstucki deleted the remove-useless-constant-extractors branch July 4, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants