Reject incomplete implicit dictionaries #6798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any RHS of a recursive implicit dictionary (after pruning) is an EmptyTree, then this indicates that implicit search failed and we should report the overall search as a failure. Fixes scala#6796
smarter
approved these changes
Jul 3, 2019
| @@ -1842,6 +1842,7 @@ final class SearchRoot extends SearchHistory { | |||
| val pruned = prune(List(tree), implicitDictionary.map(_._2).toList, Nil) | |||
| implicitDictionary0 = null | |||
| if (pruned.isEmpty) result | |||
| else if (pruned.exists(_._2 == EmptyTree)) NoMatchingImplicitsFailure | |||
There was a problem hiding this comment.
Is there a way to provide a more detailed error that would let the user know more about how the search failed?
There was a problem hiding this comment.
In principle I guess so. But it's not obvious (to me) how to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any RHS of a recursive implicit dictionary (after pruning) is an
EmptyTree, then this indicates that implicit search failed and we should report the overall search as a failure.Fixes #6796.