Fix #6795: Print flagString #6797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -284,7 +284,7 @@ class Namer { typer: Typer => | |||
| case _ => (flags.isTermFlags, flags.toTermFlags, "value") | |||
| } | |||
| if (!ok) | |||
| ctx.error(i"modifier(s) `$flags' incompatible with $kind definition", tree.sourcePos) | |||
| ctx.error(i"modifier(s) `${flags.flagsString}' incompatible with $kind definition", tree.sourcePos) | |||
There was a problem hiding this comment.
Should this not be:
`${flags.flagsString}`That is, a backtick at the end rather than a single quote?
| @@ -1504,7 +1504,7 @@ object messages { | |||
| case class AbstractMemberMayNotHaveModifier(sym: Symbol, flag: FlagSet)( | |||
| implicit ctx: Context) | |||
| extends Message(AbstractMemberMayNotHaveModifierID) { | |||
| val msg: String = em"""${hl("abstract")} $sym may not have `$flag' modifier""" | |||
| val msg: String = em"""${hl("abstract")} $sym may not have `${flag.flagsString}' modifier""" | |||
There was a problem hiding this comment.
Same thing with the backtick here
tests/neg/i6795-b.check
Outdated
| -- [E083] Syntax Error: tests/neg/i6795-b.scala:1:11 ------------------------------------------------------------------- | ||
| 1 |sealed def y: Int = 1 // error | ||
| | ^ | ||
| | Modifier(s) sealed not allowed for method |
There was a problem hiding this comment.
I think we should be consistent in how we quote these modifiers. If erased is quoted with backticks, sealed should be as well
anatoliykmetyuk
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.