Skip to content

Perform full check that a the contents of a macro are valid in PrepareInlineable #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

nicolasstucki
Copy link
Contributor

Avoid check duplication

@nicolasstucki nicolasstucki requested a review from liufengyun July 2, 2019 15:30
@nicolasstucki nicolasstucki self-assigned this Jul 2, 2019
All splices at level -1 or lower are now caught by typer
@nicolasstucki nicolasstucki force-pushed the fix-macro-splice-checks branch from 38b7923 to e54c112 Compare July 2, 2019 18:47
@nicolasstucki nicolasstucki marked this pull request as ready for review July 2, 2019 19:56
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 60d1fbd into scala:master Jul 3, 2019
@nicolasstucki nicolasstucki deleted the fix-macro-splice-checks branch July 3, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants