Skip to content

Add missing QuoteContext to Liftable.toExpr #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add missing QuoteContext to Liftable.toExpr #6785

merged 1 commit into from
Jul 3, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 2, 2019 •
edited
Loading

Add context to Liftable.toExpr. The rest is updating and adaptations to fit this new required QuoteContext.

@nicolasstucki nicolasstucki requested a review from liufengyun July 2, 2019 11:56
@nicolasstucki nicolasstucki force-pushed the add-QuoteContext-to-Liftable branch 4 times, most recently from b3cd066 to 63f6bf3 Compare July 2, 2019 14:28
@nicolasstucki nicolasstucki self-assigned this Jul 2, 2019
@nicolasstucki nicolasstucki force-pushed the add-QuoteContext-to-Liftable branch 2 times, most recently from 1d19c58 to e531fe9 Compare July 2, 2019 15:43
@nicolasstucki nicolasstucki force-pushed the add-QuoteContext-to-Liftable branch from cf30aa8 to 0e5acc0 Compare July 3, 2019 09:19
@nicolasstucki nicolasstucki marked this pull request as ready for review July 3, 2019 09:51
liufengyun
liufengyun approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a breaking change. But as it's not yet a widely used feature and there is a simple source level fix, it should be fine.

@nicolasstucki nicolasstucki merged commit ea57e36 into scala:master Jul 3, 2019
@nicolasstucki nicolasstucki deleted the add-QuoteContext-to-Liftable branch July 3, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun