Fix #6734: Suppress interpolation for extension methods #6780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress interpolation in the middle of an ExtMethodApply. The reason is that the ExtMethodApply has a WildcardType, which hides information about bound type variables in the result type.
smarter
requested changes
Jul 1, 2019
There was a problem hiding this comment.
I would push this check up the stack in simplify, where we already have some similar checks before calling interpolateTypeVars: https://github.com/lampepfl/dotty/blob/33666e9f66dc61ff3868a2132db55a72f39d4d27/compiler/src/dotty/tools/dotc/typer/Typer.scala#L2209-L2213
smarter
reviewed
Jul 1, 2019
Co-Authored-By: Guillaume Martres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress interpolation in the middle of an ExtMethodApply. The reason is that
the ExtMethodApply has a WildcardType, which hides information about bound type
variables in the result type.