Change rules for exports to make them more useful for enums #6729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
change-export-rules
branch
2 times, most recently
from
57da77f to
01f6669
Compare
Two changes:
- The forwarder alising a value definition gets a singleton type referring
to the alias
- Synthetic members are not exported by a wildcard export
This means we can now safely write
```
enum MatchDegree {
case NoMatch, ParamMatch, FullMatch
}
export MatchDegree._
```
and export just the three enum values with the most precise types. (precision
is necessary for exhaustiveness checks, among others).
odersky
force-pushed
the
change-export-rules
branch
from
62582e9 to
f11239e
Compare
Leaks can be avoided by following type aliases. Previously, this was only done if the checked symbol is a term. But it is not clear why types should not get the same treatment. This avoids a problem in pos/reference/exports.scala.
We export values under their singleton types only if the original value was already public. Otherwise this would provoke a leak.
nicolasstucki
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
to the alias.
This means we can now safely write
and export just the three enum values with the most precise types. (precision
is necessary for exhaustiveness checks, among others).