Ignore all kinds of ProtoTypes instead of just AppliedProtos #6715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liftToClasses used to drop an opaque types from the set of types whose companion modules are included. Opaque types do not have companion modules, but their prefixes might, so it is incorrect to drop them.
The difference is that in an alias type `p.A = q.B` we take `p` instead of `q` as the prefix to search.
In blocks, conditionals and matches we mapped applied prototypes to WildcardTypes in order to force eta expansions. With extension methods the same problem arises for SelectionProtos as well. Furthermore, it makes to sense to propagate a ViewProto into a local context. So the consistent thing to do is to map all kinds of ProtoTypes to WildcardTypes in these situations. This fails one line in run/implicitsFuns.scala, which, however is of dubious value. (The line requires a manually inserted `apply` to propagate a `given` argument into an if-then-else, circumvening the previous "no applies propagated" strategy.
|
Based on #6712 |
Used to print: <none> does not take parameters.
What does "CB" mean here ? |
smarter
approved these changes
Jun 20, 2019
| @@ -1428,6 +1430,9 @@ object Types { | |||
| /** If this is an ignored proto type, its underlying type, otherwise the type itself */ | |||
| def revealIgnored: Type = this | |||
|
|
|||
| /** If this is a proto type, the ignored version, otherwise the type itself */ | |||
There was a problem hiding this comment.
I would expect "ignored version" to mean "IgnoredProto" but we always map to WildcardType instead, so maybe the documentation should read:
Suggested change
| /** If this is a proto type, the ignored version, otherwise the type itself */ | |
| /** If this is a proto type, WildcardType, otherwise the type itself */ |
| (lead /: tp.classSymbols)(joinClass) | ||
| case tp: TypeRef => | ||
| val sym = tp.symbol | ||
| if (sym.isClass || sym.isOpaqueAlias) tp |
There was a problem hiding this comment.
The same condition is repeated in the definition of isLiftTarget just below, this could be refactored.
| @@ -575,8 +582,10 @@ trait ImplicitRunInfo { self: Run => | |||
| def computeIScope() = { | |||
| val liftedTp = if (isLifted) tp else liftToClasses(tp) | |||
| val refs = | |||
| if (liftedTp ne tp) | |||
| if (liftedTp ne tp) { | |||
| implicitsDetailed.println(i"lifted of $tp = $liftedTp") | |||
|
CB = "Community Build". The shapeless 3 part failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In blocks, conditionals and matches we mapped applied prototypes to
WildcardTypes in order to force eta expansions. With extension methods
the same problem arises for SelectionProtos as well. Furthermore,
it makes no sense to propagate a ViewProto into a local context. So the
consistent thing to do is to map all kinds of ProtoTypes to WildcardTypes
in these situations.
This fails one line in run/implicitsFuns.scala, which however is of dubious value.
(The line requires a manually inserted
applyto propagate agivenargumentinto an if-then-else, circumventing the usual "no applies propagated" strategy.)