Skip to content

Remove library/src-2.x #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki force-pushed the remove-scala-2.x-dotty-lib-files branch from aac798a to 682d919 Compare June 20, 2019 09:32
@nicolasstucki nicolasstucki requested a review from smarter June 20, 2019 09:34
@nicolasstucki nicolasstucki self-assigned this Jun 20, 2019
@nicolasstucki
Copy link
Contributor Author

@smarter, moving library/src-3.x into library/src caused the following error

[error] -- [E046] Cyclic Error: /tmp/1/library/src/scala/IArray.scala:30:2 -------------
[error] 30 |  def empty[T: ClassTag]: IArray[T] = new Array[T](0)
[error]    |  ^
[error]    |  Cyclic reference involving object IArray

did you encountered similar issues when creating those source directories?

@smarter
Copy link
Member

smarter commented Jun 20, 2019

No, I don't know what the issue is.

@smarter
Copy link
Member

smarter commented Jun 20, 2019

It's probably just that moving the files around changes the order in which they end up being compiled, and this exposes a bug which is specific to some ordering of the input files.

@nicolasstucki nicolasstucki force-pushed the remove-scala-2.x-dotty-lib-files branch from ba8a435 to bb706ba Compare June 20, 2019 21:30
@nicolasstucki nicolasstucki changed the title Remove library/src-2.x and library/src-3.x Remove library/src-2.x Jun 21, 2019
@nicolasstucki
Copy link
Contributor Author

@smarter I left part of moving src-3.x into src for another PR as it will take some time debugging.

@nicolasstucki nicolasstucki merged commit b8ed0df into scala:master Jun 21, 2019
@nicolasstucki nicolasstucki deleted the remove-scala-2.x-dotty-lib-files branch June 21, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants