Skip to content

[WIP] Fix #4986 Support implicitNotFound in Method Def. #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tOverney
Copy link
Contributor

@tOverney tOverney commented Jun 18, 2019

Still at least two open issues/wip:

  • Unlike in 2.13, the message from @implicitNotFound is not valided to check if the $xx actually exist in the scope and emit a warning.
  • The resolution of those $xx when emitting the error is not correct/too simple.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@smarter
Copy link
Member

smarter commented Apr 3, 2020

@tOverney Good news! :) #8637 was just merged which means you can call paramSymss on the symbol of a method to get the symbols of its parameters, and thus get the annotations on these parameters. This should make it possible to put @implicitNotFound on the parameter name instead of the parameter type like in Scala 2.

@b-studios
Copy link
Contributor

Since #4986 is closed, I am closing this draft PR as well. @tOverney please let me know if we should revive it.

@b-studios b-studios closed this Apr 27, 2021
@tOverney
Copy link
Contributor Author

@b-studios no, I should have closed it when @prolativ opened the pr;
Sorry @smarter I wasn't able to jump back in that PR last year :(

@tOverney tOverney deleted the implictNotFound branch April 27, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants