Fix #643 - Scala2 unpickling now sets NoInits flag for interfaces. #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
16 tests failed with StaleSymbolError |
|
I am on it. UNravelling a rather interesting thread. |
Refinement classes and their members could give spurious stale symbol errors if the symbol is loaded in a different run than the classfile containing it. The problem is that refinement classes do not form part of the scope of their owners. The fix assumes that refinement classes are always "stillValid".
Found while trying to chase down the problem with stale symbols in last commit. Double negation is confusing. The new formulation avoids it.
The previous stale symbol was discovered because NormalizeFlags looks at all declarations of a MoInits trait in the SymTransformer. I.e it does this for all no-init traits, whether loaded from a classfile or currently compiled. This is wasteful because it forces too many definitions. The new scheme drops the scan in favor of producing PureInterface together with NoInits. PureInterface is already read as a flag from Java snd Scala2 classfiles. For source and Tasty it is now generated as members are indexed.
Instead of classifying class members with a TreeInfo.DefKind, we use directly the flags into which kinds were previously translated.
NoInits is implied for pure interfaces, so has to be set. The Java classfile parser already does the right thing here.
odersky
force-pushed
the
fix/#643-scala2-noinits
branch
from
97f6348 to
0e6b857
Compare
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Jun 19, 2015
Fix #643 - Scala2 unpickling now sets NoInits flag for interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassfileParser did it already correctly, but Scala2 unpickler did not. Review by @DarkDimius
Note: Course-2002-07 now crashes with a different error.