Fix missing position assertion failure #6581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are macros, the positions are not set automatically due to different source files.
nicolasstucki
approved these changes
May 29, 2019
liufengyun
added a commit
to liufengyun/scalatest
that referenced
this pull request
May 29, 2019
It depends on the following fix to the compiler: scala/scala3#6581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are macros, the positions are not set automatically due
to different source files.
The problem is encountered in ScalaTest, where missing positions
result in compiler crash. Unfortunately, it is not easy to minimize.