-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Avoid creating ScalaInstance when not used #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
val isD = isDotty.value | ||
val si = scalaInstance.taskValue | ||
val siTaskInitialize = Def.valueStrict { si } | ||
if (isD) dottyScalaInstance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we inline some of this stuff ? e.g.
if (isDotty.value) Def.task { ... }
else Def.valueStrict { ... }
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split things out so each step is easier to understand (for me). You can inline as much as you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is related to this change
|
Failure is unrelated, the dottyLatestNightlyBuild task from sbt-dotty is looking for a nightly of dotty_0.16 but we won't have one until tonight's build (because we just released 0.15 and bumped version today), someone should make that task more robust. |
The bug is fixed now, so this PR passes the CI. |
No description provided.