Skip to content

Improve parser inline documentation #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2019
Merged

Improve parser inline documentation #6500

merged 2 commits into from
May 15, 2019

Conversation

Jentsch
Copy link
Contributor

@Jentsch Jentsch commented May 13, 2019

While fooling around with the idea of allowing extends private ... in the parser if found some inconsistencies in the JavaDoc of Parsers.scala.
I assumed that `someName' means the same as ‘someName’ and the later one the currently used syntax. Is that correct?

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes

@odersky odersky merged commit d3a9a91 into scala:master May 15, 2019
@Jentsch Jentsch deleted the improve-parser-inline-documentation branch February 17, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants