Skip to content

Fix #6415: Enable REPL code completion for opaque types #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019
Merged

Fix #6415: Enable REPL code completion for opaque types #6429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/ast/Desugar.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ object desugar {
val moduleName = tdef.name.toTermName
val localRef = Select(Ident(moduleName), tdef.name)
localRef.pushAttachment(SuppressAccessCheck, ())
val aliasType = cpy.TypeDef(tdef)(rhs = completeForwarder(localRef))
val aliasType = cpy.TypeDef(tdef)(rhs = completeForwarder(localRef)).withSpan(tdef.span.startPos)
val localType = tdef.withMods(Modifiers(Synthetic | Opaque).withPrivateWithin(tdef.name))

val companions = moduleDef(ModuleDef(
Expand Down
4 changes: 4 additions & 0 deletions compiler/test/dotty/tools/repl/TabcompleteTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,8 @@ class TabcompleteTests extends ReplTest {
@Test def moduleCompletion = fromInitialState { implicit s =>
assertEquals(List("Predef"), tabComplete("object Foo { type T = Pre"))
}

@Test def i6415 = fromInitialState { implicit s =>
assertEquals(List("Predef"), tabComplete("opaque type T = Pre"))
}
}