Test demonstrating extension method shorthands #6339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shows that the overhead of extension methods can be reduced to be no more than 7 characters per method, using two tricks: - Any implicit parameters become parameters of the enclosing implied instance - A local type alias can be used to abbreviate the (repetitive) first parameter string. This demonstration strengthens the case for the current syntax for extension methods.
odersky
force-pushed
the
add-extmethod-test
branch
from
7f3f5c6 to
eefe66f
Compare
smarter
reviewed
Apr 18, 2019
|
|
||
| implied StringListOps given TC { | ||
| type T = List[String] | ||
| def (x: T) foo (y: T) = (x ++ y, the[TC]) |
There was a problem hiding this comment.
It's an interesting trick, but I'm afraid that it'll make signature information less readable in error messages and in the IDE (e.g. if I'm writing a.foo(, then a signature popup will tell me that an argument of type T is expected), and dealiasing all the time before showing type information is likely to be even less readable in general.
There was a problem hiding this comment.
Well, in practice it would probably be named This or Self or Left, not T. And of course we should have defined foo like this:
def (x: T) foo (y: List[String]) = ...Then the signature popup gives you the right info again.
|
Nice trick. I'll give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test shows that the overhead of extension methods can be reduced
to be no more than 7 characters per method, using two tricks:
string.
This demonstration strengthens the case for the current syntax for extension methods.