Remove staged tuples #6311
Merged
Remove staged tuples #6311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now tuples had two implementations, one with staging and one with plain inline and inliner constant folding. The second one was used in practice as the first one could not be used if tuples where used (macros expanded) in the library due to bootstrapping issues. These implementations were never intended to actually be used, they mostly showed the power of match types, inline and staging. Eventually, this logic will be special cased in the compiler for performance.
biboudis
reviewed
Apr 16, 2019
|
We would have to duplicate the logic in Tuple. Not sure it is worth it or even possible without some hard coded logic in the compiler. |
|
Something manual and minimal by just using |
|
I will hack something up to test it as a run test |
biboudis
approved these changes
Apr 16, 2019
ghost
removed
the
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now tuples had two implementations, one with staging and one with plain inline
and inliner constant folding. The second one was used in practice as the first one could not be used if tuples where used (macros expanded) in the library due to bootstrapping issues.
These implementations were never intended to actually be used, they mostly showed the power of match types, inline and staging. Eventually, this logic will be special cased in the compiler for performance.