Fix #6247: Remove incorrect early check #6301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-interpolate-locked
branch
from
b623112 to
4746041
Compare
odersky
approved these changes
Apr 15, 2019
The check relied on the assumption that `locked` is always contained in `state.ownedVars`, but this can stop being true when an owned type variable is garbage-collected.
smarter
force-pushed
the
fix-interpolate-locked
branch
from
4746041 to
c626647
Compare
|
A regression for Dotty happened after this PR? |
|
Yes, see #6331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check relied on the assumption that
lockedis always contained instate.ownedVars, but this can stop being true when an owned typevariable is garbage-collected.