Skip to content

Improve error/warning error format #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

Use red for error, yellow for warnings and blue for info.

Previously all warnings looked like errors:
Screenshot 2019-04-11 at 22 41 27

Now we can easely diferentiate them (blue is still kept for info):
Screenshot 2019-04-11 at 22 41 38

Use red for error, yellow for warnings and blue for info.
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think blue is a bit hard to read on the black background. Btw, same goes to the current Dotty error reporting. I always select the Dotty error output before reading it. What do you think about experimenting with a whiter color?

@nicolasstucki
Copy link
Contributor Author

I agree that the color pallet is not ideal. We should have a look into it later. In that case will need to find globally all uses of color and change them to be consistent. It is also important to check that the colors also look good on white.

@anatoliykmetyuk anatoliykmetyuk merged commit e591684 into scala:master Apr 12, 2019
@ghost ghost removed the stat:needs review label Apr 12, 2019
@SethTisue SethTisue changed the title Improve error/waring error format Improve error/warning error format Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants