Add TASTy Reflect Pattern.Wildcard #6275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This inconsistency was discovered while implementing #6274 |
nicolasstucki
force-pushed
the
add-tasty-reflect-pattern-wildcard
branch
5 times, most recently
from
da6bc89 to
7ff2fee
Compare
liufengyun
approved these changes
Apr 11, 2019
| @@ -304,6 +305,9 @@ trait Core { | |||
| /** Pattern representing a `x: Y` type test. */ | |||
| type TypeTest = kernel.TypeTest | |||
|
|
|||
| /** Pattern representing a `_` pattern */ | |||
| type Wildcard = kernel.Wildcard | |||
|
|
|||
There was a problem hiding this comment.
A little concern for flattened Pattern names: Wildcard has different meanings in different places, it may cause confusion.
Maybe WildcardPattern -- as most macros will not touch patterns, a long name will not affect usability.
There was a problem hiding this comment.
I renamed it to WildcardPattern
Wildcard are represented with Ident but are not valid terms. The current API exposed them an the contens on a Pattern.Value which advertives them as Terms. To avoid we add Pattern.WildcardPattern and stop returning them from Pattern.Value.
nicolasstucki
force-pushed
the
add-tasty-reflect-pattern-wildcard
branch
from
7ff2fee to
59e378a
Compare
liufengyun
approved these changes
Apr 11, 2019
| def unapply(pattern: Pattern)(implicit ctx: Context): Boolean = | ||
| kernel.matchPattern_WildcardPattern(pattern).isDefined | ||
| } | ||
|
|
There was a problem hiding this comment.
Minor (no need to address in this PR): we could use just Wildcard here, as there is no worry for conflict or confusion.
Maybe we can avoid flattening types for seldomly used categories like TypeTrees and Patterns to reduce conflicts and confusions.
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcard are represented with Ident but are not valid terms. The current API exposed them an the contens on a Pattern.Value which advertives them as Terms. To avoid we add Pattern.Wildcard and stop returning them from Pattern.Value.