Fix TASTY reflect examples #6265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `'x` is deprecated symbol syntax, not splicing (yet) - without by-name parameter passing anything else than a constant will not work (`Expr[Int]` will be `Ident(x)`)
dottybot
reviewed
Apr 9, 2019
Thanks botty, you too! 🌋 |
LPTK
reviewed
Apr 9, 2019
nicolasstucki
approved these changes
Apr 9, 2019
nicolasstucki
suggested changes
Apr 9, 2019
Co-Authored-By: jrudolph <[email protected]>
nicolasstucki
approved these changes
Apr 10, 2019
|
Thanks @jrudolph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'xis deprecated symbol syntax, not splicing (yet)Expr[Int]will beIdent(x))(Is that requirement of the by-name modifier explained somewhere? Is it a consequence / interaction of how the inline modifier works?)