Skip to content

Add regression test #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Apr 4, 2019

Add regression test of a version of the xml string interpolator that can track the xml scope using contextual parameters.

This will be used to encode the logic in fixScopes without any hacky postprocessing.

With a version of the xml string interpolator that can track the xml scope using contextual parameters.
@nicolasstucki
Copy link
Contributor Author

@yibnl this will be useful for you

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit aa59bef into scala:master Apr 4, 2019
@nicolasstucki nicolasstucki deleted the add-xml-str-interpol-regression-test branch April 4, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants