Add quoted patterns #6198
Merged
Add quoted patterns #6198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,4 +16,7 @@ object Quoted { | |||
| def typeQuote[T <: AnyKind]: Type[T] = | |||
| throw new Error("Internal error: this method call should have been replaced by the compiler") | |||
|
|
|||
| /** A splice in a quoted pattern is desugared by the compiler into a call to this method */ | |||
| def patternHole[T]: T = | |||
There was a problem hiding this comment.
Note: this is the equivalent to def hole[T] in #6042, not to be confused with object patternHole { def unapply[T] = ... }.
|
Status: FromTasty test fails on |
Also, cleanup some other stuff. Not done with this yet, but it is crucial that we follow the same pattern everywhere in Definition, or otherwise people will get hopelessly confused. Right now some of the more recent additions use naming conventions that deviate from what was intended.
Previously, the case where arity = 1 was treated specially.
Now we can have patterns that do not have a full tree (i.e. just an Ident to the `unapply`)
nicolasstucki
force-pushed
the
add-quote-patterns
branch
from
acc9423 to
3cef701
Compare
|
Rebased |
|
@nicolasstucki Your commits LGTM |
nicolasstucki
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.