Preliminary fix needed for the full bootstrap #6194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded scala-2.12 won't be valid once we bootstrap.
This lead to crashes in the full bootstrap and doesn't seem necessary in any case.
When compiling and running the tests for the bridge, we should have the bootstrapped library on the classpath since this is what people will actually use in the end. This is tricky to do since the bridge itself cannot be compiled with anything bootstrapped on the classpath since the bootstrapped projects need the bridge to be compiled ! We sidestep this issue by using two separate projects for the bridge and its tests.
1. If we don't give a parent to the URLClassLoader constructor, it will use the system ClassLoader by default, which includes the jars in the JVM classpath. 2. `getResourceAsStream` will first look for the resource in a parent ClassLoader. 3. The reference compiler is in the JVM classpath. So if the reference compiler is Dotty-compiled, we might pick up .tasty files from it instead of the current compiler. Using `null` as the parent ClassLoader avoids this problem.
We don't need to do anything special to compile code with dotty anymore, but we do need to have the bootstrapped library on the classpath.
This test runs the compiler using -usejavacp which doesn't really work when a non-bootstrapped Dotty is on the classpath.
They require having the current compiler on the classpath, and the non-bootstrapped compiler cannot be loaded if it was compiled with an old Dotty.
smarter
force-pushed
the
prepare-bootstrap
branch
from
1933890 to
dc0c818
Compare
nicolasstucki
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.